cheminfo / chromatography

Tools for storing, search and analyze GC/MS spectra
https://cheminfo.github.io/chromatography
MIT License
9 stars 5 forks source link

Calculate series for lock mass #14

Closed maasencioh closed 7 years ago

maasencioh commented 7 years ago

missing:

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-3.6%) to 96.133% when pulling f0f6b20cee6a0c83b1c363426faa69b18caaeb55 on massLock into 77afd5a248524e2a1dbd80fb72c83609913bd0ba on master.

codecov-io commented 7 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@77afd5a). Click here to learn what that means. The diff coverage is 100%.

@@            Coverage Diff            @@
##             master      #14   +/-   ##
=========================================
  Coverage          ?   99.71%           
=========================================
  Files             ?       16           
  Lines             ?      352           
  Branches          ?        0           
=========================================
  Hits              ?      351           
  Misses            ?        1           
  Partials          ?        0
Impacted Files Coverage Δ
src/applyLockMass.js 100% <100%> (ø)
src/index.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 77afd5a...e37356f. Read the comment docs.

maasencioh commented 7 years ago

Hello @lpatiny I don't understand this comment

We should also be sure that if there are 2 ms spectra and 2 lock mass is also works correctly

You mean to add a test case like this one?

let ms = [
  [[100, 200, 300], [10, 20, 30]],
  [[622.024747], [274]],
  [[100, 200, 300], [10, 20, 30]],
  [[522.024747], [274]]
];
lpatiny commented 7 years ago

I was thinking about a test very similar to yours

let ms = [
  [[100, 200, 300], [10, 20, 30]],
  [[622], [274]],
  [[400, 500, 600], [40, 50, 60]],
  [[623], [274]]
];
coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.03%) to 99.716% when pulling e37356f509f94a7cae1c4966ead0800a4e785cc6 on massLock into 77afd5a248524e2a1dbd80fb72c83609913bd0ba on master.

maasencioh commented 7 years ago

@lpatiny I think that this part it's ready, what do you think?