Closed maasencioh closed 7 years ago
:exclamation: No coverage uploaded for pull request base (
master@77afd5a
). Click here to learn what that means. The diff coverage is100%
.
@@ Coverage Diff @@
## master #14 +/- ##
=========================================
Coverage ? 99.71%
=========================================
Files ? 16
Lines ? 352
Branches ? 0
=========================================
Hits ? 351
Misses ? 1
Partials ? 0
Impacted Files | Coverage Δ | |
---|---|---|
src/applyLockMass.js | 100% <100%> (ø) |
|
src/index.js | 100% <100%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 77afd5a...e37356f. Read the comment docs.
Hello @lpatiny I don't understand this comment
We should also be sure that if there are 2 ms spectra and 2 lock mass is also works correctly
You mean to add a test case like this one?
let ms = [
[[100, 200, 300], [10, 20, 30]],
[[622.024747], [274]],
[[100, 200, 300], [10, 20, 30]],
[[522.024747], [274]]
];
I was thinking about a test very similar to yours
let ms = [
[[100, 200, 300], [10, 20, 30]],
[[622], [274]],
[[400, 500, 600], [40, 50, 60]],
[[623], [274]]
];
@lpatiny I think that this part it's ready, what do you think?
missing: