search

cheminfo / chromatography

Tools for storing, search and analyze GC/MS spectra
https://cheminfo.github.io/chromatography
MIT License
9 stars 5 forks source link

feat(meanFilter): filter a serie2D by it's median #36

Closed maasencioh closed 7 years ago

maasencioh commented 7 years ago

@lpatiny what do you think that should be the behavior?

chrom.meanFilter('ms', {factor: 2});
chrom.merge( 'ms', [[1, 2]], {
    algorithm: 'slot',
    delta: 1
})

or

chrom.merge( 'ms', [[1, 2]], {
    meanFactor: 2,
    algorithm: 'slot',
    delta: 1
})
codecov-io commented 7 years ago

Codecov Report

Merging #36 into master will increase coverage by 0.03%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #36      +/-   ##
==========================================
+ Coverage      99%   99.03%   +0.03%     
==========================================
  Files          32       33       +1     
  Lines         602      623      +21     
  Branches      128      133       +5     
==========================================
+ Hits          596      617      +21     
  Misses          6        6
Impacted Files Coverage Δ
src/ms/meanFilter.js 100% <100%> (ø)
src/Chromatogram.js 97.43% <100%> (+0.17%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1025fdf...c7802ad. Read the comment docs.