search

cheminfo / isotherm-analysis

JS tools to convert isotherms to jcamp and to analyze them
https://cheminfo.github.io/isotherm-analysis/
MIT License
0 stars 0 forks source link

Size of xlsx ?? #27

Closed lpatiny closed 3 years ago

lpatiny commented 3 years ago

The build version of the package:

-rw-r--r--   1 lpatiny  staff  1847285 Oct 13 07:50 isotherm-analysis.js

If I comment this export: // export { fromBelsorp } from './from/fromBelsorp';

-rw-r--r--   1 lpatiny  staff  358875 Oct 13 07:55 isotherm-analysis.js

Is it really related to xlsx ?

kjappelbaum commented 3 years ago

https://github.com/SheetJS/sheetjs/issues/1640

i can look into using the mini build.

kjappelbaum commented 3 years ago

Hm ...

i didn't get 

 alias({
        entries: [{ find: './dist/cpexcel.js', replacement: '' }],
      }),

to work

kjappelbaum commented 3 years ago

also, looking at this we cannot exclude this apparently because according to https://github.com/SheetJS/sheetjs/issues/438#issuecomment-286000026 it is needed for xls, which we need to read.

lpatiny commented 3 years ago

Thanks for investigation. Indeed we can do nothing about it but at least we know where it is coming from.