search

cheminfo / mass-tools

Various projects dealing with molecular formula
https://cheminfo.github.io/mass-tools/
MIT License
7 stars 0 forks source link

breaking change in patch release of mf-generator #72

Closed targos closed 2 years ago

targos commented 2 years ago

The function now returns a Promise, which breaks the chromatography package Commit: https://github.com/cheminfo/mass-tools/commit/a9dbc396cd5e5f441490a19cc1912e5d1ee4c5c6

Moreover, there is nothing async happening in the function, so it could just stay sync.

targos commented 2 years ago

@lpatiny

targos commented 2 years ago

I understand why you did the change, but it is a huge break and extremely annoying to work with it.

targos commented 2 years ago

I guess there's not much we can do here apart from propagating the change to the other package...