cheminfo / mass-tools

Various projects dealing with molecular formula
https://cheminfo.github.io/mass-tools/
MIT License
7 stars 0 forks source link

feat: getMatchingScore #85

Closed RicardoSilvestr closed 1 year ago

codecov[bot] commented 2 years ago

Codecov Report

Base: 93.37% // Head: 93.38% // Increases project coverage by +0.01% :tada:

Coverage data is based on head (f8502ab) compared to base (700b4de). Patch coverage: 95.65% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #85 +/- ## ========================================== + Coverage 93.37% 93.38% +0.01% ========================================== Files 154 155 +1 Lines 4423 4446 +23 Branches 1311 1318 +7 ========================================== + Hits 4130 4152 +22 - Misses 272 273 +1 Partials 21 21 ``` | [Impacted Files](https://codecov.io/gh/cheminfo/mass-tools/pull/85?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cheminfo) | Coverage Δ | | |---|---|---| | [...ges/ms-spectrum/src/getFragmentedCandidateScore.js](https://codecov.io/gh/cheminfo/mass-tools/pull/85/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cheminfo#diff-cGFja2FnZXMvbXMtc3BlY3RydW0vc3JjL2dldEZyYWdtZW50ZWRDYW5kaWRhdGVTY29yZS5qcw==) | `95.45% <95.45%> (ø)` | | | [packages/ms-spectrum/src/index.js](https://codecov.io/gh/cheminfo/mass-tools/pull/85/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cheminfo#diff-cGFja2FnZXMvbXMtc3BlY3RydW0vc3JjL2luZGV4Lmpz) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cheminfo). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=cheminfo)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

lpatiny commented 2 years ago

Please check that you have all thos eoptions in your vscode settings

https://github.com/cheminfo/generator-cheminfo/blob/main/START.md

  "editor.defaultFormatter": "esbenp.prettier-vscode",
  "editor.formatOnSave": true,
  "editor.codeActionsOnSave": {
    "source.fixAll.eslint": true
  },
  "files.eol": "\n",
  "js/ts.implicitProjectConfig.checkJs": true,
RicardoSilvestr commented 2 years ago

Please check that you have all thos eoptions in your vscode settings

https://github.com/cheminfo/generator-cheminfo/blob/main/START.md

  "editor.defaultFormatter": "esbenp.prettier-vscode",
  "editor.formatOnSave": true,
  "editor.codeActionsOnSave": {
    "source.fixAll.eslint": true
  },
  "files.eol": "\n",
  "js/ts.implicitProjectConfig.checkJs": true,

I have all this options and no error appeared in the code

RicardoSilvestr commented 1 year ago

Node 12 error happens because jest does not accept the question mark operator:

Details:

    /home/runner/work/mass-tools/mass-tools/packages/ms-spectrum/node_modules/ml-spectra-processing/lib/matrix/matrixCreateEmpty.js:8
        const { matrix, nbRows = matrix?.length || 1, nbColumns = matrix?.[0].length || 1, ArrayConstructor = Float64Array, } = options;
                                        ^

    SyntaxError: Unexpected token '.'

Node 14 fails just because of AbortSignal.timeout function, otherwise it passes.

Node 16 and 18 were failing because of a DNS issue (that's what i found online) and it was just enough to restart docker and the problem was solved.