cheminfo / mzData

Read and explore mzData files.
https://cheminfo.github.io/mzData/
MIT License
1 stars 2 forks source link

Improve speed by parsing XML to a JSON first #7

Closed lpatiny closed 6 years ago

lpatiny commented 6 years ago

The speed is improved by a factor of around 3.

@targos

Should be compatible with previous format (buffer) in Browser and Node the preferred format is now to receive a String.

Before it was:

And now

codecov[bot] commented 6 years ago

Codecov Report

Merging #7 into master will decrease coverage by 0.24%. The diff coverage is 96.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
- Coverage   96.49%   96.25%   -0.25%     
==========================================
  Files           2        6       +4     
  Lines          57       80      +23     
  Branches       16       21       +5     
==========================================
+ Hits           55       77      +22     
- Misses          2        3       +1
Impacted Files Coverage Δ
src/parseCvParam.js 100% <100%> (ø)
src/util/ensureText.js 100% <100%> (ø)
src/processSpectrumList.js 100% <100%> (ø)
src/processMetaData.js 100% <100%> (ø)
src/index.js 100% <100%> (+4.25%) :arrow_up:
src/decodeData.js 81.25% <81.25%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bb5d7ab...38ba2df. Read the comment docs.