search

cheminfo / nmrium

React component to display and process nuclear magnetic resonance (NMR) spectra.
https://docs.nmrium.org
MIT License
55 stars 25 forks source link

Non intuitive close icon #1449

Open lpatiny opened 2 years ago

lpatiny commented 2 years ago

Currently we have the icon 'x' to cancel a change.

image

It appears however that this is not intuitive because we can see in some cases 'live' changes and we don't expect that clicking on 'x' that seems like closing a dialog box would actually revert the changes.

If it reverts changes we should replace the 'x' icon by 'ban':

image

If it just closes the dialog box without reverting anything we can keep the 'x'.

@targos @stropitek sounds ok to you ?

targos commented 2 years ago

Another option could be to use buttons at the bottom of the dialog (and nothing at the top). "Save" and "Cancel" for example

stropitek commented 2 years ago

@stropitek sounds ok to you ?

SGTM

Another option could be to use buttons at the bottom of the dialog (and nothing at the top). "Save" and "Cancel" for example

would lean towards this but I think consistency is more important so whichever way you go it needs to be consistent throughout the app