search

cheminfo / nmrium

React component to display and process nuclear magnetic resonance (NMR) spectra.
https://docs.nmrium.org
MIT License
55 stars 25 forks source link

Experimental FT for 2D spectra #2235

Closed lpatiny closed 11 months ago

lpatiny commented 1 year ago

@hamed-musallam

Could you prepare new buttons for 2D processing:

Those 3 buttons will need options (the 3)

For Zero filling we will need 2 zero filling, for first and second dimensions For apodization we will also need the options for the 2 dimensions For FT we should be able to select if we want to make FT in both dimensions or not.

All those buttons should be hidden behind the experimental features and this will help @jobo322 to implement the code.

hamed-musallam commented 1 year ago

Do you think it is better to wait until we see what options that Alejandro needs for each filter before we add those tools(buttons) in the main toolbar

lpatiny commented 1 year ago

Can indeed just be a toolbar with 'apply' 'cancel' 'preview' but currently no options.

image

hamed-musallam commented 1 year ago

@lpatiny after I checked, maybe we do not need to create a different tool for 2d, we can use the same 1D tools and based on Nucleus we apply the 1D filter or the 2D filter, WDT?

hamed-musallam commented 11 months ago

closed by https://github.com/cheminfo/nmrium/pull/2294