cheminfo / nmrium

React component to display and process nuclear magnetic resonance (NMR) spectra.
https://docs.nmrium.org
MIT License
55 stars 25 forks source link

Automatic zone detection crashes on 2D raw data #2411

Closed jliermann closed 1 year ago

jliermann commented 1 year ago

If applied to 2D raw data, automatic zone detection crashes.

Methods to reproduce: a)

b)

Workaround:

Suggestion:

@evaziegler

lpatiny commented 1 year ago

Many thanks for your bug report. This will be fixed on the next release and can be already tested on https://dev.nmrium.org/#/SamplesDashboard/rzp8qc9ysak/Viewcytisine2ddatacytisine2dalljson

We hope to put the new version in production this week-end.

jliermann commented 1 year ago

On dev, I can still reproduce the bug when including 2D raw data?

lpatiny commented 1 year ago

Actually it crash when there is a 2D FID. @hamed-musallam could you check that no zone picking is done on the raw data.

We have a test case here:

https://dev.nmrium.org/#/SamplesDashboard/m9p3oa8cnxg/Viewcytisine2ddatacytisine2dHMBC_HN_Cytisinjson

2023-06-15 17 25 27

hamed-musallam commented 1 year ago

fixed in https://github.com/cheminfo/nmrium/pull/2472