Recolor spectra on 2D

[lpatiny]

Would be nice that recolor spectra also works on 2D. For now we can only recolor the positive part of the 2D.

[hamed-musallam]

The recoloring functionality is working but it takes into account the constant colors which we defined in the past based on the experiment value.

https://github.com/cheminfo/nmrium/blob/bc28413e2b82ea62cee7600addb2a4b1e5738058/src/data/utilities/generateColor.ts#L26-L33

[lpatiny]

Ok I see. I would then have 2 buttons, one for 'Set predefined colors' and the current one for 'Recolor'

With the current behavior, is it normal that even if I delete all the predefined colors

recolor does nothing ?

[hamed-musallam]

As you know we recently added the feature of predefined colors which differs from what you're currently observing.

https://github.com/cheminfo/nmrium/blob/bc28413e2b82ea62cee7600addb2a4b1e5738058/src/data/utilities/generateColor.ts#L26-L33

Within the color function, we initially search for predefined custom colors. If none are found, we then check for constant colors. If neither exists, we generate a random color

[hamed-musallam]

I suggest updating the constant colors to align with the latest schema we agreed upon. Additionally, we can have two buttons: one to apply the color preferences and the other to generate colors randomly

[lpatiny]

So I think the 2 buttons approach (default and distinct) is the way to go.

I also get strange results when I try to recolor using the contextual menu.

[hamed-musallam]

So I think the 2 buttons approach (default and distinct) is the way to go.

I also get strange results when I try to recolor using the contextual menu.

This may not be an issue in 1D but it is in 2. It should rely on column (experiment) values to generate the colors but it seems is not, I will check why this not working but the question should we generate a random color in this case or we should keep relying on experiment to ensure consistency

[lpatiny]

Yes it should be a random color in this case. Same is true in 1D. If we recolor by distinct value (contextual menu) we should have one color per distinct value.

[hamed-musallam]

This applies to all other information except for the experiment column. For the experiment column, should it be a random color too, or based on the predefined colors?

[lpatiny]

If we have the button to reset the experiment colors I think the contextual menu should always make the random color.