search

cheminfo / nmrium

React component to display and process nuclear magnetic resonance (NMR) spectra.
https://docs.nmrium.org
MIT License
55 stars 26 forks source link

feat: PNG export resolution #3237

Closed hamed-musallam closed 2 months ago

cloudflare-workers-and-pages[bot] commented 2 months ago

Deploying nmrium with  Cloudflare Pages  Cloudflare Pages

Latest commit: 74099dc
Status: ✅  Deploy successful!
Preview URL: https://f211d16a.nmrium.pages.dev
Branch Preview URL: https://png-dpi.nmrium.pages.dev

View logs

targos commented 2 months ago

Having the concept of a "resolution" (in DPI) in this context really feels weird to me, because a spectrum has no size in the real world, but ok...

hamed-musallam commented 2 months ago

Yes, I'm aware of this 💯, but this is what came to mind as it seems close to what we're aiming for. It's simply a matter of rescaling the spectrum to meet the desired needs.

lpatiny commented 2 months ago

The functionality looks ok to me. In the future probably we will indeed need to specify the size of the image like we do for printing to PDF. And then dpi would indeed make sense. Did well to plan an object for the options ;)

lpatiny commented 2 months ago

Will be improved in: