search

cheminfo / nmrium

React component to display and process nuclear magnetic resonance (NMR) spectra.
https://docs.nmrium.org
MIT License
55 stars 26 forks source link

feat: improve 1D line broadening filter #3260

Closed jobo322 closed 1 week ago

jobo322 commented 1 month ago
cloudflare-workers-and-pages[bot] commented 1 month ago

Deploying nmrium with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0da03c7
Status: ✅  Deploy successful!
Preview URL: https://5b1dec99.nmrium.pages.dev
Branch Preview URL: https://2931-crash-at-the-moment-to.nmrium.pages.dev

View logs

lpatiny commented 1 month ago

First conflict should be solved and then I don't know which issue is solved with this PR.

jobo322 commented 3 weeks ago

@targos @lpatiny, optional parameters does not exist anymore in filters. In nmrium there is a conflict in the onLoadProcessing:

-https://github.com/cheminfo/nmrium/blob/main/src/demo/views/SnapshotView.tsx#L428-L433

I propose do not use the same type of Filters, then at the moment to apply the filters we could completed the options needed

lpatiny commented 2 weeks ago

@jobo322 Did you check why the testcases are not passing ?

lpatiny commented 1 week ago

@targos We may need your help to debug the lint-check-types problem.

We have the following error is we run npx tsc --noEmit --traceResolution

======== Resolving module '../../../data/utilities/getAtomsFromMF.js' from '/Users/lpatiny/git/cheminfo/nmrium/src/component/panels/SummaryPanel/SetMolecularFormulaModal.tsx'. ========
Module resolution kind is not specified, using 'NodeNext'.
Resolving in ESM mode with conditions 'import', 'types', 'node'.
Loading module as file / folder, candidate module location '/Users/lpatiny/git/cheminfo/nmrium/src/data/utilities/getAtomsFromMF.js', target file types: TypeScript, JavaScript, Declaration, JSON.
File name '/Users/lpatiny/git/cheminfo/nmrium/src/data/utilities/getAtomsFromMF.js' has a '.js' extension - stripping it.
File '/Users/lpatiny/git/cheminfo/nmrium/src/data/utilities/getAtomsFromMF.ts' exists - use it as a name resolution result.
======== Module name '../../../data/utilities/getAtomsFromMF.js' was successfully resolved to '/Users/lpatiny/git/cheminfo/nmrium/src/data/utilities/getAtomsFromMF.ts'. ========
/Users/lpatiny/git/cheminfo/nmrium/node_modules/typescript/lib/tsc.js:120986
      throw e;
      ^

RangeError: Map maximum size exceeded
    at Map.set (<anonymous>)
    at checkTypeRelatedTo (/Users/lpatiny/git/cheminfo/nmrium/node_modules/typescript/lib/tsc.js:63276:16)
    at isTypeRelatedTo (/Users/lpatiny/git/cheminfo/nmrium/node_modules/typescript/lib/tsc.js:63188:14)
    at isTypeStrictSubtypeOf (/Users/lpatiny/git/cheminfo/nmrium/node_modules/typescript/lib/tsc.js:62312:12)
jobo322 commented 1 week ago

At the moment open the general settings it throws an error:

image
jobo322 commented 1 week ago

The filters in the processings panel can't be removed.

hamed-musallam commented 1 week ago

Zones panel preferences are not working anymore