cheminfo / nmrium

React component to display and process nuclear magnetic resonance (NMR) spectra.
https://docs.nmrium.org
MIT License
55 stars 25 forks source link

file name for visualization of multiple experiments #388

Closed nes-cgn closed 4 years ago

nes-cgn commented 4 years ago

If multiple spectra are displayed – would it be possible/make sense to also show the name of the individual files to better distinguish them? E.g. in the spectra or information section of accordion menu

hamed-musallam commented 4 years ago

@lpatiny Where do you think it's better to show the file name?

lpatiny commented 4 years ago

The first column in the list of spectra is not the names ? @nes-cgn image

hamed-musallam commented 4 years ago

@lpatiny No it's a label we are define it inside the JSON file, do you want to replace it with the file name

hamed-musallam commented 4 years ago

@nes-cgn After I checked the code we already use the File name as a label but because the examples that we used its build manually, we named the files.

you can check that by drag and drop any jcamp file on the Displayer and you will see that we used the file name

nes-cgn commented 4 years ago

Hello Hamed,

I am not convinced. Check the file that I attach: It is a zipped
Bruker file from our lates spectrometer, and besides the fact that I
cannot properly import it, it also does not show the proper file name.
I add another one from the 500 MHz (also latest Bruker Software) and
it does not show the name, neither),

Nils

Zitat von hamed-musallam notifications@github.com:

@nes-cgn After I checked the code we already use the File name as a label but
because the examples that we used its build manually, we named the
files.

you can check that by drag and drop any jcamp file on the Displayer
and you will see that we used the file name