search

cheminfo / nmrium

React component to display and process nuclear magnetic resonance (NMR) spectra.
https://docs.nmrium.org
MIT License
55 stars 25 forks source link

Zones picking in combined HSQC/HMBC without labels. Displayer crashed when zoomed HMBC is picked #617

Closed nes-cgn closed 3 years ago

nes-cgn commented 3 years ago

(1) When the dataset 'HSQC/HMBC cytisine' (General section) ist chosen and only the HSQC is displayed, the zones tool does not show the dots for the defined crosspeaks, even though the zones table gets populated. (2) When the HSQC is deselected and the HMBC is picked with the zones tool, this only works as long as the entire spectrum is visible. If you first zoom into a region to selectively pick the zones, the interface crashes. zones_HSQC_3_061020 zones_HSQC_HMBC_1_061020 zones_HSQC_HMBC_2_061020

lpatiny commented 3 years ago

Second point can not be reproduced but maybe fixed in the meantime.

nes-cgn commented 3 years ago

I made a movie for the second point (first, zones on entire spectrum - without the zone-centers being picked! - and then zoom-in and zones from expanded reagion - leads to crash (at least on my computers) bug_617.zip

hamed-musallam commented 3 years ago

@nes-cgn I fixed it right now. To show the zones you have to set negative or positive signal visible by click on the eye icon, like what we have in below image image

nes-cgn commented 3 years ago

Not so sure. At least for me, if I have the HMBC active (HSQC also deactivated by eye icons to avoid confusion), I can zoom in this region and then select 2-3 zones, but again, at some point it crashed