Closed kjappelbaum closed 3 years ago
Merging #11 (08b8961) into master (15198e1) will increase coverage by
1.94%
. The diff coverage is87.06%
.
@@ Coverage Diff @@
## master #11 +/- ##
==========================================
+ Coverage 83.50% 85.44% +1.94%
==========================================
Files 9 11 +2
Lines 97 213 +116
Branches 17 60 +43
==========================================
+ Hits 81 182 +101
- Misses 14 29 +15
Partials 2 2
Impacted Files | Coverage Δ | |
---|---|---|
src/compoundData/getExperimentalData.js | 76.92% <76.92%> (ø) |
|
src/compoundData/getComputedData.js | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 15198e1...08b8961. Read the comment docs.
Should be squashed before merging.
Implements "Parsers" for basic computed and experimental properties. @lpatiny It is still "dirty" but maybe you can give it a look if you're fine with the overall approach. If you're ok I'll add more properties + tests and clean up.
Experimental properties
js-quantities
if this works out, we use them to summarize using mean/median/stdev. The benzene test case has multiple entries for boiling and melting point, some of which we cannot easily parse.details
output will contain the raw strings for all referencesComputed properties
Apparently, for computed properties, there is always only one float. Sometimes with the unit, sometimes without. For this reason, i decided against the
returnDetails
option. The output will be of the formwhere
references
is of the same form as everywhere else.General
I didn't yet add the methods to the
CompoundData
class.