search

cheminfo / tga-spectrum

https://cheminfo.github.io/tga-spectrum/
MIT License
0 stars 2 forks source link

typescript #41

Closed lpatiny closed 2 years ago

lpatiny commented 2 years ago
lpatiny commented 2 years ago

@targos If you have time to have a look to this typescript migration.

In order to make the build I need to import @types/react because in common-spectrum we generate directly the react-plot JSON format. However in this package we don't export this kind of chart and I would expect that the tree shaking would remove everything related to react-plot. I don't know if there is something wrong at this level.

targos commented 2 years ago

In order to make the build I need to import @types/react because in common-spectrum we generate directly the react-plot JSON format. However in this package we don't export this kind of chart and I would expect that the tree shaking would remove everything related to react-plot.

That's the right thing to do, but it should be done in the project that uses @types/react (so, common-spectrum). That said, it would be better to avoid these types altogether in libraries that are not related to react components.