search

cheminfo / tga-spectrum

https://cheminfo.github.io/tga-spectrum/
MIT License
0 stars 2 forks source link

fromTAInstruments bugs for first last line #8

Closed lpatiny closed 4 years ago

lpatiny commented 4 years ago

First and last lines contains negative values of time

StartOfData
-3.000000   1.000000    0.0000000   0.0000000   0.0000000
6.66667E-4  22.70189    20.82160    10.06382    90.00909

Those values should be ignored

@kjappelbaum I will simply add a filter checking that the time if >= 0

kjappelbaum commented 4 years ago

I actually did it with purpose---i didn't like to delete any data. I forgot that this makes issues for the visualization, but i feel this should be handled then there (and the jcamp should contain the negative values). But maybe I'm too opinionated here.

lpatiny commented 4 years ago

I will rather consider this as a bug in the data and remove them. It would rather be unintuitive for the end user to have to select a filter that filters the x value so that they are bigger than 0. By default we would anyway display all the values.

lpatiny commented 4 years ago

Actually it is not a bug but describes some changes -3 would mean change of gas ?

image

There is one more '-3' later in the file.

lpatiny commented 4 years ago

I pushed my changes (I also removed papaparse that is not really required here)

kjappelbaum commented 4 years ago

you're right in all. I'm really sorry for being sloppy here and thanks for fixing it!