cheminfo / tools

CLI tools to help cheminfo developers
MIT License
2 stars 3 forks source link

chore: remove namedExports option, add nodePolyFills #232

Closed kjappelbaum closed 4 years ago

kjappelbaum commented 4 years ago

-The namedExports option from @rollup/plugin-commonjs is deprecated. Named exports are now handled automatically. https://github.com/rollup/plugins/pull/410

targos commented 4 years ago

The named exports removal sgtm. Can you show me a project where nodePolyFills is needed?

kjappelbaum commented 4 years ago

I think i'll need nodePolyFills here https://github.com/cheminfo/xrd-tools.

But I agree with you that it is probably better to keep this out of this PR and do it later when needed. Just removed this part from the PR.