search

chen-rn / CUA

(deprecateed) create-universal-app(CUA) is an opinionated template for creating fullstack universal apps (Expo, Next, tRPC, Prisma, Clerk, Solito, Tamagui)
https://cua-demo.vercel.app
MIT License
1.02k stars 67 forks source link

PNPM upgrade #27

Closed Necmttn closed 1 year ago

vercel[bot] commented 1 year ago

Deployment failed with the following error:

Could not parse File as JSON: apps/nextjs/vercel.json
chen-rn commented 1 year ago

Would you mind double checking that pnpm works with EAS build?

That was the main reason why I chose to go with Yarn instead of PNPM at the time of starting this template.

Necmttn commented 1 year ago

EAS build

Will check in theory, it should work

Necmttn commented 1 year ago

Having issues with expo/router 😅 before it gets to EAS

chen-rn commented 1 year ago

oh darn! Expo-router shouldn't interfere with the package manager, should it? I remember create-t3-turbo uses pnpm, and I just couldn't get it to work. I believe they ended up patching it but it had to do with react native and pnpm, not necessarily expo.

What are the main benefits of PNPM when hoisting is disabled?

VidunderGunder commented 1 year ago

I use pnpm in an almost identical stack (has to stay private, though) and it's running in production on TestFlight with no hiccups. Very strongly prefer pnpm myself even though it doesn't play nicely with Expo, so I could take a jab at this if I get some time next weekend. @ me if someone wants to try and you face any specific issues.

chen-rn commented 1 year ago

Ah that's great to hear! what would you say are the main advantages/disadvantages of pnpm over yarn3 for a universal stack?

Also, does it deploy to vercel nicely as well?

Necmttn commented 1 year ago

Hey @VidunderGunder would you have time to pair on it ? I'm trying to setup with pnpm but kept getting errors, would love to see your setup

VidunderGunder commented 1 year ago

@chen-rn Haven't gone to web for prod yet, but that's one of my next priorities in that project. Considering swapping over to this if I can get all my nice-to-haves from that project into CUA.

Personally, I appreciate pnpm's speed and storage savings, and I love that you can set a Node.js version and it will automatically use that exact version. I also feel that the semantics of commands are more inline with Turbo as well.

Btw, I hadn't heard about tamogui before, so I'm excited to see how it compares to my current setup using dripsy + moti and before that NativeWind. So thanks for opening my eyes to it.

Here's a legacy and unpolished starter I made as my first jab at native development, that uses NativeWind, moty, dripsy, Three.js (with the native variant for native) and Skia (didn't have time to get it to work for web, though), if someone wants some inspo:
create-xp-app

@Necmttn Yeah, sure - that would be nice. Here's a time slot I have open for tomorrow, if that could work.