Use Spinners instead of pulldowns

[GoogleCodeExporter]

For some controls it might make more sense to use spinner controls instead
of pull-downs with predefined values.

Specifically, I would like to see:

- radius
- stroke-width

We could also experiment with opacity, but I think I like the simple
pull-downs for that.

The biggest amount of work will be to find a license-compatible jquery
plugin that implements a spinner control and is accessible.

Original issue reported on code.google.com by codedr...@gmail.com on 17 Jun 2009 at 10:21

[GoogleCodeExporter]

I think http://docs.jquery.com/UI/Spinner + jquery.mousewheel would be the 
best, but 
I'm not sure how much code will be added with UI library.

Original comment by rusn...@gmail.com on 18 Jun 2009 at 9:30

[GoogleCodeExporter]

It looks like you can do a custom build of jquery UI: 
http://jqueryui.com/download so
we might want to consider that.  On first glance, I couldn't figure out how to 
get
just the spinner (maybe it's included with Slider?).

I agree that if it adds too much code then it's probably not worth it.

Original comment by codedr...@gmail.com on 18 Jun 2009 at 2:21

[GoogleCodeExporter]

I just deselected everything but Core and Spinner:

179.65 kb uncompressed
~119.65 kb minified

We're not going to use jQuery UI any time soon.  Need to look for something 
that just
does spinners.

I found this one last night: http://www.softwareunity.com/jquery/JQuerySpinBtn/ 
and
emailed the person to ask about licenses.  If you think we can use it 
(license-wise)
based on his 'half-inch' comment, then I'm definitely open to it.

I downloaded it and the JS, CSS and GIF are 9881 bytes and that's before 
minifying or
compressing anything.

I have not tried it out though.

Original comment by codedr...@gmail.com on 18 Jun 2009 at 2:34

[GoogleCodeExporter]

other alternatives:

http://plugins.jquery.com/project/spin-button
http://plugins.jquery.com/project/wheelspiner

* combination of these two would be nice :D
* both are GPLv2 :-(, but we can ask for less strict license

Original comment by rusn...@gmail.com on 18 Jun 2009 at 3:24

[GoogleCodeExporter]

I just integrated http://www.softwareunity.com/jquery/JQuerySpinBtn/ into my 
working
copy and it looks and works pretty good.  Should I check it in - maybe make 
another
branch?

Original comment by codedr...@gmail.com on 18 Jun 2009 at 3:34

[GoogleCodeExporter]

Please create a separate branch for that. Until we're not sure with the license 
it 
makes no sense to commit into the trunk. Also the field has problem with 
non-numeric 
text in it.

PS: I would love to have the spinner/slider/combobox combination used in some 
editors. Not sure how easy/hard would it be to create one in jQuery-> see 
http://
ftp.pcworld.com/pub/screencams/marin_sf_02.jpg - Size/Hardness/... fields - for 
example)

Original comment by rusn...@gmail.com on 18 Jun 2009 at 3:48

[GoogleCodeExporter]

the correct link is http://ftp.pcworld.com/pub/screencams/marin_sf_02.jpg

Original comment by rusn...@gmail.com on 18 Jun 2009 at 3:49

[GoogleCodeExporter]

Ok, I've created a branch for this work
http://svg-edit.googlecode.com/svn/branches/spinner/editor/svg-editor.html

Let me know what you think - I don't see any problem with non-numeric input 
(you can
enter non-numeric text but when you press enter the spinner resets to 0).

Also, please read over the text in the .js and .css of the spinbtn - it might 
be easy
to interpret this as a 'do-what-you-want' with this kind of thing.  I'm not a 
lawyer
though, so I'll wait to hear back from George.

I do think the spinner+slider+combobox would be cool, but no idea how hard it 
would
be.  Ultimately I think the best bet would be for us to bite the bullet and go 
with
jQuery UI as that is the right license, has some corporate support, etc.  We can
decide on this much later on though.

Original comment by codedr...@gmail.com on 18 Jun 2009 at 4:05

[GoogleCodeExporter]

Pavol had the following objections:
http://groups.google.com/group/svg-edit/msg/077c830de2789eb4

I'm guessing he is working on a little popup control for stroke width and 
style.  For
rect radius, I am still investigating the spinner control now that it has been
properly licensed.

Original comment by codedr...@gmail.com on 6 Jul 2009 at 7:33

[GoogleCodeExporter]

On Tue, Jun 23, 2009 at 3:05 AM, Pavol Rusnak<rusnakp@gmail.com> wrote:
>  I have some objections against current state of spinner:
>
> * when I press the arrow key I would except that the spinner has
>  autorepeat feature (I'm not sure whether this is possible ...)
>
> * spinner has no live-preview (when I enter the number I have to press
>  one of the arrow keys to launch the update event, Enter works only in
>  Firefox, not in Opera)
>

I have updated the spinner branch by modifying the jquery plugin for
these two issues:

http://svg-edit.googlecode.com/svn/branches/spinner/editor/svg-editor.html

- Now the edit box updates the canvas as you type
- holding down the up/down arrows now cause key-repeat events (at
least in Linux and OSX)

Can someone test this in Windows by any chance?

If there are no further objections, I'd like to merge these into the trunk.

Original comment by codedr...@gmail.com on 6 Jul 2009 at 8:46

[GoogleCodeExporter]

Jeff, great! Autorepeat and update works. You can merge the changes into trunk. 
Also 
please try to send your modifications to plugin upstream to see if they are 
interested. Thanks!

Original comment by rusn...@gmail.com on 6 Jul 2009 at 9:49

[GoogleCodeExporter]

Committed in r278

Original comment by codedr...@gmail.com on 7 Jul 2009 at 1:21

• Changed state: Fixed