search

chenditc / safari-download

chrome extension to help download book from safari
Apache License 2.0
169 stars 42 forks source link

change of format ? #29

Closed DickBaker closed 5 years ago

DickBaker commented 5 years ago

I am getting error "I'm not able to get the book title, please check if you have logged in with a valid account. A valid account means you can load and read the full book. If you are sure you have logged in, please report this incidence to: https://github.com/chenditc/safari-download/issues" on [all] titles, such as https://www.safaribooksonline.com/library/view/tensorflow-machine-learning/9781789132212

I suspect that Safari have changed their underlying format to .xhtml such as this URL https://www.safaribooksonline.com/library/view/tensorflow-machine-learning/9781789132212/5019f99e-22fc-426e-8ec9-a63030cdbb48.xhtml

BTW I am fully logged-in and able to navigate online to any page within this/other title.

Would it be possible to accommodate this strict flavour of html so that this useful extension can be brought back to life ?

thanks

chenditc commented 5 years ago

I tried the link you provided, and I was able to download the book. Please check if you are using the latest version of the plugin.

chenditc commented 5 years ago

tensorflow_machine_learning_projects.zip https://drive.google.com/a/umich.edu/file/d/1yZMeJu2NAvzjobD2rlFmMTt9TrzmQp9Y/view?usp=drive_web I tried with the latest version of the plugin, and here is the zip file it produce.

On Fri, Dec 7, 2018 at 9:31 PM Dick Baker notifications@github.com wrote:

I am getting error "I'm not able to get the book title, please check if you have logged in with a valid account. A valid account means you can load and read the full book. If you are sure you have logged in, please report this incidence to: https://github.com/chenditc/safari-download/issues" on [all] titles, such as https://www.safaribooksonline.com/library/view/tensorflow-machine-learning/9781789132212

I suspect that Safari have changed their underlying format to .xhtml such as this URL

https://www.safaribooksonline.com/library/view/tensorflow-machine-learning/9781789132212/5019f99e-22fc-426e-8ec9-a63030cdbb48.xhtml

BTW I am fully logged-in and able to navigate online to any page within this/other title.

Would it be possible to accommodate this strict flavour of html so that this useful extension can be brought back to life ?

thanks

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/chenditc/safari-download/issues/29, or mute the thread https://github.com/notifications/unsubscribe-auth/ADGDLXeLsk0PzdLD50wmefkouvF6TYA5ks5u2m3DgaJpZM4ZIcux .