search

chenditc / safari-download

chrome extension to help download book from safari
Apache License 2.0
169 stars 42 forks source link

Not working in http://techbus.safaribooksonline.com/ #3

Closed jhomzki closed 6 years ago

chenditc commented 7 years ago

I don't have access to http://techbus.safaribooksonline.com/, what is this site for?

jhomzki commented 7 years ago

This the old site for safari books online. I'm just thinking if this can be added to your code..

On Oct 22, 2016 5:36 AM, Di notifications@github.com wrote:

I don't have access to http://techbus.safaribooksonline.com/, what is this site for?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/chenditc/safari-download/issues/3#issuecomment-255471236, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AV3bJcq8vDTJqOkPsK0MNm367p8UhJIKks5q2TBggaJpZM4Kan8O.

chenditc commented 7 years ago

Oh... ok. For now, this tool fits all my needs, so I don't realy want to dig into old site that might get retired sometime in the future.

Sent from my iPhone

On Oct 25, 2016, at 14:54, jhomzki notifications@github.com wrote:

This the old site for safari books online. I'm just thinking if this can be added to your code..

On Oct 22, 2016 5:36 AM, Di notifications@github.com wrote:

I don't have access to http://techbus.safaribooksonline.com/, what is this site for?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/chenditc/safari-download/issues/3#issuecomment-255471236, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AV3bJcq8vDTJqOkPsK0MNm367p8UhJIKks5q2TBggaJpZM4Kan8O.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

lawilap commented 7 years ago

http://techbus.safaribooksonline.com/ is not an old but a subsidiary part of safaribooksonline, its mostly used by corporate employees who gets access to safaribooks via their organisation. I tried adding this to your code, but it didn't work, maybe I'm doing something wrong. Can you please guide me where can I make changes to get this extension working on techbus domain. Million thanks from all those who are waiting for your response.

GitHubSouceCodeAdmin commented 7 years ago

I agree with Lawilap, it would be really helpful if you could add in support for techbus.safaribooksonline.com because it's a huge part of safari. Many people, and new accounts use that. It has to do with how they provision various types of catalogs. This is one of the largest ones

multiflexi commented 6 years ago

proquest.safaribooksonline.com would be also nice as it is used by universities.

gylns commented 6 years ago

does it work for ezproxy url?

watsoncl commented 6 years ago

I can't seem to get the extension to work via "proquest.safaribooksonline.com"

chenditc commented 6 years ago

Only standard "www.safaribooksonline.com" is supported. You are welcome to fork this repo and support your own need.