search

chenditc / safari-download

chrome extension to help download book from safari
Apache License 2.0
169 stars 42 forks source link

New Function Added : Automatically download all books from Safari Queue #8

Open bschung5 opened 7 years ago

bschung5 commented 7 years ago

I added a function that can automatically download all books in the Safari Queue of the user. This batch downloading function reduced the time wasted on manually start new downloading job of another book. Hope you will merge this pull request.

chenditc commented 7 years ago

Sounds like an interesting feature, let me take a look.

thiagonogueira commented 7 years ago

Any chance having this feature published in the master? I have more than 30 books to be downloaded.

Regards, Thiago

chenditc commented 7 years ago

The major reaeson I didn't merge this pull requests:

"download all books concurently" doesn't sounds like a good idea, espcially when you allow at most 100 books to download at same time. Chrome will fork more than 100 processes to download these books and certainly crash user's computer because they can use a lot of memory. (You can test this out)