VIVO-1816: i18n: tabs on profile page unclickable after deleting an entry

chenejac commented 4 years ago

Alexander J. Jerabek (Migrated from VIVO-1816) said:

From the profile page: http://localhost:8080/vivo/display/n7257

Route: Organizations > [Chemistry] > Profile page > Contacts tab > Add 'phone' Organisations > [Chimie] > Profile page > Coordonnées > Ajouter 'Téléphone'

Here are the steps.

from the main profile page, click on 'Contacts'
create a new phone number
automatic return to Contacts page
click on garbage can icon to delete the phone number
number is delete, automatic return to 'Overview' tab
'Hand' icon shows on hover over tabs, but no tabs are clickable.

Verified in english and french version, and on Chrome v81, and FF Devloper v76

chenejac commented 3 years ago

Matthias Lühr said:

The problem resides in js/individual/propertyGroupControls.js:

after editing a location.hash is provided to open a specific group tab
adding a phone number provides a hash of "#ARG_2000028" what is working
after deleting a phone number the provided hash contains the encoded complete URI of the property ("#https%3A%2F%2Fpurl.obolibrary.org...") which breaks the java script code

How to fix this? Where does the redirect come from and where is the hash generated?

chenejac commented 3 years ago

Matthias Lühr said:

It looks like something is mangling the predicateURI in the n3editing of the contact information.

The n3edit configuration looks like this:

...

subjectUri=https://vivo.hs-mittweida.de/vivo/individual/n2576 varNameForSubject= predicateUri=http://purl.obolibrary.org/obo/ARG_2000028 varNameForPredicate= object=[https://vivo.hs-mittweida.de/vivo/individual/n6226]

...

Note: predicateUri should contain "http://purl.obolibrary.org/obo#ARG_2000028".

As a consequence the localname of the predicateUri is computed incorrect in the DeletePropertyController class.

chenejac commented 3 years ago

Matthias Lühr said:

I have to correct myself... it seems the the following code taken from the DeletePropertyController won't work with the OBO Ontology:

String predicateUri = EditConfigurationUtils.getPredicateUri(vreq); int hashIndex = predicateUri.lastIndexOf("#"); String localName = predicateUri.substring(hashIndex + 1);

since [http://purl.obolibrary.org/obo/ARG_2000028] is actually the correct URI...

chenejac commented 3 years ago

Matthias Lühr said:

It's a bug in wilma indeed. VIVO 1.11.1 behaves the same way given that the wilma theme is used.

tenderfoot doesn't show that behaviour (and seems not to rely on propertyGroupControls.js).

chenejac commented 3 years ago

Matthias Lühr said:

https://github.com/vivo-project/VIVO/pull/202

chenejac commented 3 years ago

Matthias Lühr said:

Not sure if "fixed" - but providing a workaround for non-bootstrap-based themes, like wilma (and fred).

chenejac commented 3 years ago