Closed chenejac closed 3 years ago
Benjamin Gross said:
+Questions+
My votes are no, no, and no.
Benjamin Gross said:
Pull request: [https://github.com/vivo-project/Vitro/pull/165]
Andrew Woods said:
Pending response to code review.
Andrew Woods said:
Looks good. Next reviewer can merge.
Benjamin Gross (Migrated from VIVO-1839) said:
Currently, VIVO produces a list of flags. There are potentially issues with representing the languages this way. For one, languages don't always fall neatly into countries. Thinking about Simplified and Traditional Chinese at the moment. Arabic is another good example. Michel also brings up countries with multiple common languages, like Canada.
Instead of selecting languages by country flag, I propose a text dropdown. Something like this:
!Screen Shot 2020-04-17 at 12.23.35 PM.png|thumbnail!