search

chenejac / VIVOTestMigration

0 stars 0 forks source link

VIVO-1850: i18n : Typos in French version of "Output of" form (2) #1735

Open chenejac opened 4 years ago

chenejac commented 4 years ago

Nicolas B Dickn (Migrated from VIVO-1850) said:

In

People > [some individual] > Other > Output of > Add

Originally in https://jira.lyrasis.org/browse/VIVO-1818

chenejac commented 3 years ago

Benjamin Gross said:

This is not a simple i18n swap since the help text is generated based on the property name.

It is concatenated here: [https://github.com/vivo-project/Vitro/blob/sprint-i18n/webapp/src/main/webapp/templates/freemarker/edit/forms/js/customFormWithAutocomplete.js#L701.] 

It doesn't really make a lot of sense in english in this case either. 

Here is a case where the logic works better:

!Screen Shot 2021-01-26 at 5.43.33 PM.png!

Though I couldn't tell you if it makes sense in french.

!Screen Shot 2021-01-26 at 5.44.31 PM.png!

 

 

Perhaps the solution is to change the help text to something along the lines of 'Chose an existing object' vs trying to be smart and append the object property type.

chenejac commented 3 years ago

Benjamin Gross said:

Suggestion from sprint wrap up call: "Select an existing value"