chenejac / VIVOTestMigration

0 stars 0 forks source link

VIVO-1873: Internationalize SPARQL query page #1758

Closed chenejac closed 4 years ago

chenejac commented 4 years ago

Benjamin Gross (Migrated from VIVO-1873) said:

English is hard-coded into admin-sparqlQueryForm.ftl. Move english strings into a .properties file to enable internationalization. 

[https://github.com/vivo-project/Vitro/blob/master/webapp/src/main/webapp/templates/freemarker/body/admin/admin-sparqlQueryForm.ftl]

chenejac commented 4 years ago

Benjamin Gross said:

Should either include changes proposed in [https://github.com/vivo-project/Vitro/pull/164] or #164 should be updated if this is merged first to prevent a regression.

chenejac commented 4 years ago

Andrew Woods said:

Pull-requests:

chenejac commented 4 years ago

Andrew Woods said:

Resolved with: https://github.com/vivo-project/Vitro/commit/a990bc9030eac38a24376a1a84c2c754cb020766 and https://github.com/vivo-project/Vitro-languages/commit/33c145b1d1f7e6be262314c33daa095df193547b