search

chenejac / VIVOTestMigration

0 stars 0 forks source link

VIVO-1877: i18n : Untranslated labels in French version of "Date / Time Interval" form #1762

Closed chenejac closed 3 years ago

chenejac commented 4 years ago

Nicolas B Dickn (Migrated from VIVO-1877) said:

Issue 1

"Month", "Day", "Hour" and "Seconds" labels are untranslated in the add and edit "Date / time interval" forms.

Those labels are hardcoded in VIVO-languages\fr_CA\webapp\src\main\webapp\templates\freemarker\edit\dateTimeWithPrecision_fr_CA.ftl  - so the fix is trivial.

However, can't we do better than this? After all, the "Year" label is pulled from a properties files (see issue 2 below), so why aren't all the other labels added to properties files and pulled in the same manner? This way, we wouldn't have to duplicate/recode a different ftl file for each and every language.

Issue 2

 "Year" field labels are missing in fr_CA :

 <#if precLevel gte 1> <#-- Only text input field in the mix. We should have some validation to ensure it's a valid year (4 digits, integer, etc) -->

<input class="text-field" name="${fieldName}-year" id="${fieldName}-year" type="text" value="${year!}" size="4" maxlength="4" <#if reqLevel gte 1>required </#if>/> </#if>

chenejac commented 3 years ago

Nicolas B Dickn said:

Fixed by

Properties in [https://github.com/vivo-project/VIVO-languages/pull/89] have been translated to the best of my knowledge, but would probably require input from German and Portuguese contributors.

chenejac commented 3 years ago

Nicolas B Dickn said:

As discussed in comments, properties have moved from VIVO-languages to Vitro-languages : https://github.com/vivo-project/Vitro-languages/pull/39

chenejac commented 3 years ago

Andrew Woods said:

Resolved with: