VIVO-1893: Determinte and clean up all redundat files for new i18n support

[chenejac]

Dominik Feldschnieders (Migrated from VIVO-1893) said:

With the new extended i18n support for VIVO all languages files in VIVO- and Vitro-languages are available in the default installation of VIVO.

The default langauge is en-US.

So we can clean up old redundant files like [https://github.com/vivo-project/VIVO/blob/sprint-i18n/webapp/src/main/webapp/i18n/vivo_all.properties]

 

The task is to find all these resundant files (maybe make a list here) and delete them.  

[chenejac]

Dominik Feldschnieders said:

I found these files and deleted them:

Vitro

• webapp/src/main/webapp/i18n/all.properties

• webapp/src/main/webapp/templates/freemarker/body/accounts/userAccounts-acctCreatedEmail.ftl

• webapp/src/main/webapp/templates/freemarker/body/accounts/userAccounts-acctCreatedExternalOnlyEmail.ftl

• webapp/src/main/webapp/templates/freemarker/body/accounts/userAccounts-confirmEmailChangedEmail.ftl

• webapp/src/main/webapp/templates/freemarker/body/accounts/userAccounts-firstTimeExternalEmail.ftl

• webapp/src/main/webapp/templates/freemarker/body/accounts/userAccounts-passwordCreatedEmail.ftl

• webapp/src/main/webapp/templates/freemarker/body/accounts/userAccounts-passwordResetCompleteEmail.ftl

• webapp/src/main/webapp/templates/freemarker/body/accounts/userAccounts-passwordResetPendingEmail.ftl

• webapp/src/main/webapp/templates/freemarker/body/search/search-help.ftl

• webapp/src/main/webapp/templates/freemarker/body/termsOfUse.ftl

• webapp/src/main/webapp/i18n/ -> This folder is now empty, should it be removed too?

VIVO

• webapp/src/main/webapp/i18n/vivo_all.properties
• webapp/src/main/webapp/templates/freemarker/body/aboutQrCodes.ftl
• webapp/src/main/webapp/templates/freemarker/visualization/mapOfScience/aboutMapOfScience.ftl
• webapp/src/main/webapp/templates/freemarker/visualization/mapOfScience/mapOfScienceTooltips.ftl
• webapp/src/main/webapp/themes/tenderfoot/i18n/all.properties
• webapp/src/main/webapp/themes/wilma/i18n/all.properties

[chenejac]

Dominik Feldschnieders said:

PR 1: [https://github.com/vivo-project/Vitro/pull/170]

PR 2: [https://github.com/vivo-project/VIVO/pull/176]

[chenejac]

Andrew Woods said:

I have verified that all of the above mentioned .ftl and .properties files are represented in the six current VIVO/Vitro-languages. The only question I have is whether we prefer the "each language includes its own copy of the .ftl files" approach or the "use a single, templated set of .ftl files that each language populates with properties" approach.

[chenejac]

Andrew Woods said:

Resolved with: https://github.com/vivo-project/VIVO/commit/d1a7032db92ff4d8b55b812d3c9a4d1692ffc625 and https://github.com/vivo-project/Vitro/commit/b8b219f5c1c2870ed7c206bc85899bfea75f2e87