search

chenejac / VIVOTestMigration

0 stars 0 forks source link

VIVO-1936: i18n: Remove language flag images #1820

Closed chenejac closed 3 years ago

chenejac commented 3 years ago

Andrew Woods (Migrated from VIVO-1936) said:

As a follow-on to: https://jira.lyrasis.org/browse/VIVO-1839

The flag images can now be removed: $ find . -name 'select_locale*'

./en_US/webapp/src/main/webapp/themes/vitro/i18n/images/select_locale_en_US.gif ./en_CA/webapp/src/main/webapp/themes/vitro/i18n/images/select_locale_en_CA.png ./pt_BR/webapp/src/main/webapp/themes/vitro/i18n/images/select_locale_pt_BR.gif ./fr_CA/webapp/src/main/webapp/themes/vitro/i18n/images/select_locale_fr_CA.png ./es/webapp/src/main/webapp/themes/vitro/i18n/images/select_locale_es.png

chenejac commented 3 years ago

Andrew Woods said:

Assuming this is ready for review with:

chenejac commented 3 years ago

Benjamin Kampe said:

Updated the comment in the two runtime.properties files to instead mention that the selected language(s) must exist in the VIVO-languages and Vitro-languages repositories.

[https://github.com/vivo-project/Vitro/pull/199]

https://github.com/vivo-project/VIVO/pull/203

chenejac commented 3 years ago

Andrew Woods said:

Resolved with:

chenejac commented 3 years ago

Andrew Woods said:

Follow-on checkstyle correction: https://github.com/vivo-project/VIVO/pull/206

chenejac commented 3 years ago

Benjamin Kampe said:

F{color:#1d1c1d}ollow-up pull-request. Kept my personal config out of the commit.{color}

https://github.com/vivo-project/VIVO/pull/209

chenejac commented 3 years ago

Andrew Woods said:

See comment: https://github.com/vivo-project/VIVO/pull/209#issuecomment-768516964

chenejac commented 3 years ago

Benjamin Kampe said:

Follow-up the 2nd try: https://github.com/vivo-project/VIVO/pull/210

chenejac commented 3 years ago

Andrew Woods said:

Follow-up resolution: https://github.com/vivo-project/VIVO/commit/689e8394a946aa8108706c6bdcb4bbc7048d2437