search

chenejac / VIVOTestMigrationJIRA

0 stars 0 forks source link

VIVO-1777: i18n: 'Close' link in permalink/rdf pop-up to be translated #1669

Closed chenejac closed 4 years ago

chenejac commented 4 years ago

Alexander J. Jerabek (Migrated from VIVO-1777) said:

On any give display/nXXXX page, in the pop up (div#qtip-0) for 'Partager | URI de ce profil' :

div#qtip-0-content: close

Example: http://localhost:8080/vivo/display/n7257

chenejac commented 4 years ago

Andrew Woods said:

What is the proper translation?

chenejac commented 4 years ago

Alexander J. Jerabek said:

The french translation is 'Fermer'.

chenejac commented 4 years ago

Andrew Woods said:

Pull-request with translation fix: https://github.com/vivo-project/Vitro-languages/pull/13

chenejac commented 4 years ago

Alexander J. Jerabek said:

I have checked this fix and can confirm that it works.

chenejac commented 4 years ago

Andrew Woods said:

Resolved with: https://github.com/vivo-project/Vitro-languages/commit/bf59e4dec821526dba058d912ee504ca45c81fbb