search

chenejac / VIVOTestMigrationJIRA

0 stars 0 forks source link

VIVO-1797: i18n : Typo in add/edit forms for french version of "editor of" #1689

Closed chenejac closed 3 years ago

chenejac commented 4 years ago

Nicolas B Dickn (Migrated from VIVO-1797) said:

In

People > [some individual] > Publications > collection or series editor of > add / edit

"l'la collection" should read "la collection"

chenejac commented 4 years ago

Nicolas B Dickn said:

https://github.com/vivo-project/VIVO-languages/pull/43

chenejac commented 4 years ago

Andrew Woods said:

[~accountid:70121:d6633ae6-182e-4293-a5d8-41f16a4519d5]: The pull-request is labeled with "Draft". Is that still the case? is it ready for review?

chenejac commented 4 years ago

Nicolas B Dickn said:

42 is labeled with draft, and I should delete it. #43 is the correct one, and is ready for review

Edit: I closed #43

chenejac commented 4 years ago

Andrew Woods said:

Pending resolution of merge conflict

chenejac commented 3 years ago

Nicolas B Dickn said:

Entirely new PR, with a narrower, Reviewer Friendly™ scope  : https://github.com/vivo-project/VIVO-languages/pull/79

chenejac commented 3 years ago

Andrew Woods said:

Resolved with: https://github.com/vivo-project/VIVO-languages/commit/4482c93454addad91d5747ee4996ff541f7daf89