chenejac / VIVOTestMigrationJIRA

0 stars 0 forks source link

VIVO-1809: i18n: Add new selected publications entry publication type 'Software' should be 'Logiciel', fails to create new entry #1701

Closed chenejac closed 3 years ago

chenejac commented 4 years ago

Alexander J. Jerabek (Migrated from VIVO-1809) said:

From the profile page: http://localhost:8080/vivo/display/n7257

Route: Organizations > [Chemistry] > Profile page > Publications tab > Add a new selected publications entry Organisations > [Chimie] > Profile page > Publications tab > Ajouter une Publications choisies

In the french version 'Software' needs to be translated to 'Logiciel'

Also, selecting this type and trying to add an entry fails, no entry is created. This is also true of the english version

Page: http://localhost:8080/vivo/editRequestDispatch?subjectUri=http%3A%2F%2Flocalhost%3A8080%2Fvivo%2Findividual%2Fn7257&predicateUri=http%3A%2F%2Fvivoweb.org%2Fontology%2Fcore%23relatedBy&domainUri=http%3A%2F%2Fxmlns.com%2Ffoaf%2F0.1%2FOrganization&rangeUri=http%3A%2F%2Fvivoweb.org%2Fontology%2Fcore%23Authorship

chenejac commented 3 years ago

Nicolas B Dickn said:

I can't see the item "Software" in this menu, and as such, I can't replicate the "add an entry" problem. Maybe a data issue? Do you still see this, [~accountid:5ce5bb60eba5870dd5466dcd] ?

However, I see untranslated several rdf:label for 'Software' in the fr_CA RDF files. I'll fix that.

chenejac commented 3 years ago

Nicolas B Dickn said:

[~accountid:5d7a3f78458a170db4b08b25] can't replicate the bug either, so the problem is likely data related.

chenejac commented 3 years ago

Nicolas B Dickn said:

Untranslated term is fixed with [https://github.com/vivo-project/VIVO-languages/pull/87]

Otherwise, bug was likely data related.

chenejac commented 3 years ago

Andrew Woods said:

I do not see "Software" in the list either. Additionally, as a different issue, the title/header of the page does not appear to be fully translated:

Créer enregistrement d'une publication pour Chemistry

(although [~accountid:5ce5bb60eba5870dd5466dcd]'s screenshot shows):

Créer enregistrement d'une publication pour Chimie

chenejac commented 3 years ago

Andrew Woods said:

The PR is clearly a good fix... but would like to hold-off on merging until we hear back from [~accountid:5ce5bb60eba5870dd5466dcd].

chenejac commented 3 years ago

Nicolas B Dickn said:

[~accountid:60785ded115da6006f540529] I don't have the issue with the untranslated title. My guess is your data set simply miss a fr-CA label for that entity.

I'll signal this thread to Sacha.

chenejac commented 3 years ago

Alexander J. Jerabek said:

I'm having a bit of difficulty verifying this fix, if others have verified and Nicolas has added the missing lines then the data problem should be resolved.

chenejac commented 3 years ago

Andrew Woods said:

Resolved with: https://github.com/vivo-project/VIVO-languages/commit/61c06e628fcb661cec3f25161c841f6f93260e5c