VIVO-1814: i18n : French version of VIVO Publication graphic mouseover message is truncated

[chenejac]

Nicolas B Dickn (Migrated from VIVO-1814) said:

The French version of the mouseover message that goes along the VIVO Publications graphic got somehow truncated – quite probably because an apostrophe -wasn't escaped properly-.

Note: the cause is obviously an apostrophe in vivo_all_fr_CA.properties (line 557), but since apostrophe aren't escaped in the properties file, the bug must occur at a higher level.

[chenejac]

Nicolas B Dickn said:

I was under the impression that 

sparksText += "&nbsp;<img class='infoIcon' src='" + infoIconSrc + "' height='16px' width='16px' alt='${i18n().info_icon?js_string}' title='${i18n().numbers_based_on_publications_in_vivo?js_string}' />" ;

would work, but it does not. On the other hand :

sparksText += "&nbsp;<img class='infoIcon' src='" + infoIconSrc + "' height='16px' width='16px' alt='${i18n().info_icon?replace("'","&#39;")}' title='${i18n().numbers_based_on_publications_in_vivo?replace("'","&#39;")}' />" ; 

does work, but it's not very satisfactory.

[chenejac]

Nicolas B Dickn said:

Maybe a config issue? https://freemarker.apache.org/docs/ref_builtins_string.html#ref_builtin_html

[chenejac]

Nicolas B Dickn said:

Proposed fix : [https://github.com/vivo-project/VIVO/pull/211]

Edit: An alternative could be to tweak the configuration in /vitro-project/api/src/main/java/edu/cornell/mannlib/vitro/webapp/web/templatemodels/Tags.java,but since this config file affects the whole build, it would require a clear understanding of the consequences and a thorough testing.

[chenejac]

Andrew Woods said:

See GitHub comment for testing questions: https://github.com/vivo-project/VIVO/pull/211#issuecomment-771944467

[chenejac]

Andrew Woods said:

Related issue to the testing errors (not related to the focus of this ticket)? https://jira.lyrasis.org/browse/VIVO-1950

[chenejac]

Andrew Woods said:

Resolved with: https://github.com/vivo-project/VIVO/commit/9a2e143a52dfe915bd39f50aff703619d40a0502

[chenejac]

This issue is related to #1839