Closed chenejac closed 3 years ago
chenejac
commented
3 years ago Benjamin Gross said:
I believe the issue is that the governing authority property is not set to allow the creation of new items. If it's set the be allowed, you will see an addition option below the 'create entry' button as shown below.
!Screen Shot 2021-03-30 at 9.22.19 AM.png!
chenejac
commented
3 years ago Brian Lowe said:
Change text to "create link" or "create relationship". Check to make sure this won't adversely affect other forms.
chenejac
commented
3 years ago Benjamin Gross said:
It looks like this settings is set here in VIVO-languages. It would require another triple assertion
vivo:governingAuthorityFor vitro:offerCreateNewOptionAnnot "true"^^xsd:boolean .Benjamin Gross said:
Side note... seems like these non-text annotations should really be parsed out from the annotations file and moved to the VIVO repository.
chenejac
commented
3 years ago Brian Lowe said:
Those annotations do get moved in https://jira.lyrasis.org/browse/VIVO-1956 . It has two reviews and just needs merging.
chenejac
commented
3 years ago Benjamin Gross said:
Regarding the text strings used here, 'Create Entry' is determined by create_entry ([https://github.com/vivo-project/VIVO-languages/blob/3999807e58145d33ddbbb651b31a6cc7a54fe81f/en_US/webapp/src/main/webapp/themes/wilma/i18n/all_en_US.properties#L92)] whereas 'Add a new item of this type' is determined by add_new_of_type ([https://github.com/vivo-project/Vitro-languages/blob/d0be1df91de6d08bf32bba988abbbc84496de928/en_US/webapp/src/main/webapp/i18n/all_en_US.properties#L740).]
It appears that in some cases of custom forms, the create_entry text is used for both the situation of selecting an existing value and creating a new object to link to, however the proposed text changes are (in my opinion) still valid for that alternate situation. See example below.
!Screen Shot 2021-03-30 at 10.15.30 AM.png!
chenejac
commented
3 years ago Brian Lowe said:
Pull request that adds the annotation for "create new":
[https://github.com/vivo-project/VIVO/pull/234]
It sounds like it might make sense to split out the issue of the "create entry" text as its own issue, especially if it is used differently across forms – and since any new text we add will need to be translated into the other languages.
Alexander J. Jerabek (Migrated from VIVO-1820) said:
From the profile page: http://localhost:8080/vivo/display/n7257
Route: Organizations > [Chemistry] > Profile page > Contacts tab > Add 'governing authority for' Organisations > [Chimie] > Profile page > Coordonnées > Ajouter 'Autorité dirigeante de'
It is not possible to add a governing authority from the form provided, create entry button remains greyed out. There is no option to add a new governing authority from this page if no existing governing authorities are available.
This applies to both english and french versions.