chenejac / VIVOTestMigrationJIRA

0 stars 0 forks source link

VIVO-1821: i18n: incomplete text, placeholder text on Identity tab > add 'same as' #1712

Closed chenejac closed 3 years ago

chenejac commented 4 years ago

Alexander J. Jerabek (Migrated from VIVO-1821) said:

From the profile page: [http://localhost:8080/vivo/display/n7257]

Route: Organizations > [Chemistry] > Profile page > Identity tab > Add 'same as' Organisations > [Chimie] > Profile page > Identité > Ajouter 'même que'

Placeholder text in french on both english and french versions:

French: Ajouter un enregistrement de type Thing pour Chimie C'est la propriété d'OWL de relier deux personnes ayant la même 'identité'. Voir [http://www.w3.org/TR/owl-ref/#sameAs-def] Nom de la thing

English: Add an entry of type Thing for Chemistry C'est la propriété d'OWL de relier deux personnes ayant la même 'identité'. Voir [http://www.w3.org/TR/owl-ref/#sameAs-def] Thing Name *

Page: [http://localhost:8080/vivo/editRequestDispatch?subjectUri=http%3A%2F%2Flocalhost%3A8080%2Fvivo%2Findividual%2Fn7257&predicateUri=http%3A%2F%2Fwww.w3.org%2F2002%2F07%2Fowl%23sameAs&domainUri=http%3A%2F%2Fwww.w3.org%2F2002%2F07%2Fowl%23Thing&rangeUri=http%3A%2F%2Fwww.w3.org%2F2002%2F07%2Fowl%23Thing]

chenejac commented 4 years ago

Dominik Feldschnieders said:

For me the text is always in german, so i thing it is the same issue and has something to do with the browser location. I will look into it

chenejac commented 4 years ago

Dominik Feldschnieders said:

It looks like the Getter for public descriptions of Properties does not work good with language tags. If i go to "Site Admin" -> "Object property hierarchy" -> select "vivo:features" (or any other property with public description)  i only get one language (for me german because i live in Germany).

Can someone confirm that behavior?

chenejac commented 4 years ago

Andrew Woods said:

I am seeing translations that are mostly correct, but not completely. I believe the fundamental issue is that fr_CA and de-DE have "vitroAnnotations" files, but the other languages do not. There is a default "vitroAnnotations" file in core VIVO... which is in English. We should probably remove that file and include a "vitroAnnotations" file for each i18n language.

Specifically as it relates to de-DE, there appears to be a minor bug in the file (notice "@en-US"): https://github.com/vivo-project/VIVO-languages/blob/sprint-i18n/de_DE/home/src/main/resources/rdf/tbox/firsttime/vitroAnnotations_de-DE.n3#L1070

chenejac commented 3 years ago

Dominik Feldschnieders said:

I can confirm that the error is in the files. For the french version the language tag was not correct (see [https://github.com/vivo-project/VIVO-languages/blob/sprint-i18n/fr_CA/home/src/main/resources/rdf/tbox/firsttime/vitroAnnotations_fr_CA.ttl#L4318]) I added an english version (just a copy of the original vitroAnnotations file) and now it is working fine. I will create a PR today or tomorrow with all necessary changes but only for the existing files. 

Should i create new tickets for the other langauges where no VitroAnnotation file exists or should i translate them with google-translate for an initial version?

I think what I described before was fixed by one of your changes we talked about in the last meeting.

chenejac commented 3 years ago

Dominik Feldschnieders said:

I solved the problem, added an english version of the file and removed the default from the VIVO-Repo.

[PR 1|[https://github.com/vivo-project/VIVO-languages/pull/68]]

[PR 2|[https://github.com/vivo-project/VIVO/pull/189]]

chenejac commented 3 years ago

Andrew Woods said:

Resolved with: https://github.com/vivo-project/VIVO-languages/commit/1f1340e90cd3dc3900e8752631dd17e0903aa733 and https://github.com/vivo-project/VIVO/commit/d3e960696e9d826ef9a5490514fd3682c8f87ef6