chenejac / VIVOTestMigrationJIRA

0 stars 0 forks source link

VIVO-1825: i18n : Untranslated item in French version of "Manage concepts" #1716

Closed chenejac closed 3 years ago

chenejac commented 4 years ago

Nicolas B Dickn (Migrated from VIVO-1825) said:

In the French version of the page used to manage the list of research areas (or concepts), one of the table headers is not translated.

"Vocabulary source" would translate as "Source du vocabulaire".

chenejac commented 3 years ago

Benjamin Gross said:

Template has already been internationalized, issue is due to outdated file at https://github.com/vivo-project/VIVO-languages/blob/sprint-i18n/fr_CA/webapp/src/main/webapp/templates/freemarker/edit/forms/addAssociatedConcept_fr_CA.ftl

chenejac commented 3 years ago

Benjamin Gross said:

The solution is as simple as deleting a file.

https://github.com/vivo-project/VIVO-languages/pull/85

chenejac commented 3 years ago

Andrew Woods said:

It appears that after this PR, label becomes:

[~accountid:70121:d6633ae6-182e-4293-a5d8-41f16a4519d5]: is this ok? correct?

chenejac commented 3 years ago

Nicolas B Dickn said:

Both can work, [~accountid:60785ded115da6006f540529]. The difference is semantically subtle – and if we really feel like changing it, we'll just incorporate it to some general propertie files revision ticket later on.

chenejac commented 3 years ago

Andrew Woods said:

Resolved with: https://github.com/vivo-project/VIVO-languages/commit/fe8d53ecfb0c8e3d67928d449b206701530751e2