search

chenejac / VIVOTestMigrationJIRA

0 stars 0 forks source link

VIVO-1831: i18n : In "Create publication" form, dropdown menu has duplicate item #1722

Closed chenejac closed 3 years ago

chenejac commented 4 years ago

Nicolas B Dickn (Migrated from VIVO-1831) said:

In the "Create publication" form, the dropdown menu has a duplicate default item (both in the English and French versions).

chenejac commented 3 years ago

Benjamin Gross said:

Duplicate was added as part of [https://github.com/vivo-project/VIVO/pull/185.]

See [https://github.com/vivo-project/VIVO/blob/sprint-i18n/api/src/main/java/edu/cornell/mannlib/vitro/webapp/edit/n3editing/configuration/generators/AddPublicationToPersonGenerator.java#L896]

Can likely simply remove that one line, but need to confirm the 'select a type' text exists in all versions of addPublicationToPerson.ftl.

chenejac commented 3 years ago

Benjamin Gross said:

https://github.com/vivo-project/VIVO/pull/200

chenejac commented 3 years ago

Andrew Woods said:

Looks good. I will merge unless [~accountid:557058:3f53c733-6ac2-4e92-9f12-e34e297283a3] has comments.

chenejac commented 3 years ago

Andrew Woods said:

Resolved with: https://github.com/vivo-project/VIVO/commit/8431d12e466e04114dd87fb605fe32061ab01a73