chenejac / VIVOTestMigrationJIRA

0 stars 0 forks source link

VIVO-1837: i18n: Anonymous class labels include hard-coded English words #1728

Closed chenejac closed 4 years ago

chenejac commented 4 years ago

Brian Lowe (Migrated from VIVO-1837) said:

English-language strings such as "Restriction on," "maximum cardinality", "and," "or," "not" are built into labels for anonymous classes inside VClassDaoJena.  The most visible effect of this to an end user is that language in editing forms such as "Add a new (Collection or Document)" can only partially change in response to a user's language setting.  While the class names can be translated, the "or" cannot.

 

See also https://jira.lyrasis.org/browse/VIVO-1771

chenejac commented 4 years ago

Nicolas B Dickn said:

[~accountid:60785ded115da6006f540529] & [~accountid:557058:3f53c733-6ac2-4e92-9f12-e34e297283a3] Was this bug fixed by the related PRs?

chenejac commented 4 years ago

Andrew Woods said:

Pull-requests:

chenejac commented 4 years ago

Andrew Woods said:

Pending response to code review.

chenejac commented 4 years ago

Andrew Woods said:

Resolved with: https://github.com/vivo-project/Vitro/commit/80140a8ab0c82334a16d42708a4f22f0e2afc323 and https://github.com/vivo-project/Vitro-languages/commit/91e8d92e202fc8ce8b4daee540e4d4bc119acba0