VIVO-1839: Text option for language selection drop down

chenejac commented 4 years ago

Benjamin Gross (Migrated from VIVO-1839) said:

Currently, VIVO produces a list of flags. There are potentially issues with representing the languages this way. For one, languages don't always fall neatly into countries. Thinking about Simplified and Traditional Chinese at the moment. Arabic is another good example. Michel also brings up countries with multiple common languages, like Canada.

Instead of selecting languages by country flag, I propose a text dropdown. Something like this:

!Screen Shot 2020-04-17 at 12.23.35 PM.png|thumbnail!

chenejac commented 4 years ago

Benjamin Gross said:

+Questions+

Should flags still be option?
Do we have to indicate the 'flavor' of the language? e.g. French Canadian vs French.
Should we also display the language label in the current locale if it isn't selected? e.g. if english is currently selected: Deutsch (German)

My votes are no, no, and no.

chenejac commented 4 years ago

Benjamin Gross said:

Pull request: [https://github.com/vivo-project/Vitro/pull/165]

chenejac commented 4 years ago

Andrew Woods said:

See code review comments.

I would be happy to help with the suggestions.

chenejac commented 4 years ago

Andrew Woods said:

Pending response to code review.

chenejac commented 4 years ago