chenejac / VIVOTestMigrationJIRA

0 stars 0 forks source link

VIVO-1847: i18n: title tag and headings in capability map are in english in french version #1738

Closed chenejac closed 4 years ago

chenejac commented 4 years ago

Alexander J. Jerabek (Migrated from VIVO-1847) said:

The title tag for the french version of the capability map is in english:

Capability Map

it should be :

Cartographie des expertises

And the labels are also in english :

Term: Discours politique

and:

Group: Discours politique

Should be :

'Terme' and 'Groupe'

chenejac commented 4 years ago

Dominik Feldschnieders said:

I have made the necessary changes for all available languages in VIVO-languages. i hope that is okay

PR 1: [https://github.com/vivo-project/VIVO/pull/173]

PR 2: [https://github.com/vivo-project/VIVO-languages/pull/56]

chenejac commented 4 years ago

Andrew Woods said:

Pending response to code review comments.

chenejac commented 4 years ago

Dominik Feldschnieders said:

i responded to code review and changed everything you mentioned.  Only one question is "open", after the question has been clarified i would start the Review Process again

chenejac commented 4 years ago

Andrew Woods said:

One minor comment... then this should be good to go.

chenejac commented 4 years ago

Andrew Woods said:

Resolved with: