chenejac / VIVOTestMigrationJIRA

0 stars 0 forks source link

VIVO-1852: Minor changes to the translation in the entry page "Research" #1743

Closed chenejac closed 3 years ago

chenejac commented 4 years ago

Rachid Belkouch (Migrated from VIVO-1852) said:

"Research" page in French, from the main VIVO entry page menu :

(1) Minor changes to the text in the French translation:

So we should read (changes in {color:#ff0000}red{color}):

`Article{color:#ff0000}s{color} de recherche" "{color:#ff0000}Autres{color} article{color:#ff0000}s{color}*" "Document{color:#ff0000}s{color} audio" "Livre{color:#ff0000}s{color}" "Chapitre{color:#ff0000}s{color}" "Subvention{color:#ff0000}s{color}" "Revue{color:#ff0000}s{color}" "Prix et {color:#ff0000}d{color}istinction{color:#ff0000}s{color}" "{color:#ff0000}Expertises{color}"

(2) Minor change in the mouse over text:

For all the items in the menu, the mouse-over is "Parcourir les fiches de cette classe": it should be "Parcourir les fiches de cette {color:#ff0000}catégorie{color}"

 

 

chenejac commented 3 years ago

Benjamin Kampe said:

[https://github.com/vivo-project/Vitro-languages/pull/37]

https://github.com/vivo-project/VIVO-languages/pull/86

chenejac commented 3 years ago

Andrew Woods said:

Functionality works great. Some pull-request clean-up suggested: https://github.com/vivo-project/Vitro-languages/pull/37/commits/bba740b8c9f953d42ffa6512de324b354e2d6e60#pullrequestreview-577738817

chenejac commented 3 years ago

Benjamin Kampe said:

2nd try: https://github.com/vivo-project/Vitro-languages/pull/38

chenejac commented 3 years ago

Benjamin Gross said:

Partially resolved by https://github.com/vivo-project/Vitro-languages/commit/0fdfcacada1017ea19b64190d3799a357511d072

chenejac commented 3 years ago

Andrew Woods said:

Rest of the resolution: https://github.com/vivo-project/VIVO-languages/commit/9c00a1ccea06483b912bab04a6150f0cb0880d78