chenejac / VIVOTestMigrationJIRA

0 stars 0 forks source link

VIVO-1855: i18n : Typos in all_fr_CA.properties #1746

Closed chenejac closed 4 years ago

chenejac commented 4 years ago

Nicolas B Dickn (Migrated from VIVO-1855) said:

There are still numerous typos left in the following properties files :

that could be fixed even without being spotted in the UI.

In other words, the scope of this ticket is to fix typos, grammar and translation errors that are obvious even outside the execution context.

It might eventually overlap with other i18n tickets, which I shall mention here as I find them.

Note: This ticket excludes the single quotes, which can cause interpretation problems in Javascript, and must therefore be fixed at two different levels at once.

Edit: some single quotes were removed when rephrasing allowed it

chenejac commented 4 years ago

Nicolas B Dickn said:

[https://github.com/vivo-project/VIVO-languages/pull/47]

https://github.com/vivo-project/Vitro-languages/pull/21

chenejac commented 4 years ago

Andrew Woods said:

Is this ticket ready for review?

chenejac commented 4 years ago

Nicolas B Dickn said:

It is. Did I forget to click "Start review" button ?

chenejac commented 4 years ago

Andrew Woods said:

Resolved with: https://github.com/vivo-project/Vitro-languages/commit/fd97232e6c378d85c5c938d71c6ecb6809c41b24 and https://github.com/vivo-project/VIVO-languages/commit/089e6119c1f8aceb6a0af529c11b6a688d7daeff