Closed chenejac closed 3 years ago
Andrew Woods said:
It appears that an additional update was missed in this PR:
+++ b/webapp/src/main/webapp/templates/freemarker/body/partials/menupage/menupage-scripts.ftl
@@ -33,8 +33,7 @@
- thereAreNo: '${i18n().there_are_no?js_string}',
- indNamesStartWith: '${i18n().individuals_names_starting_with?js_string}',
+ thereAreNoEntriesStartingWith: '${i18n().there_are_no_entries_starting_with?js_string}',
Andrew Woods said:
Follow-on pull-request: https://github.com/vivo-project/Vitro/pull/183
Follow-on resolution: https://github.com/vivo-project/Vitro/commit/2863d1f094ce460a2f779d42a25a1e07ca77abeb
Nicolas B Dickn (Migrated from VIVO-1870) said:
In
the variables
are declared with the values
extracted from
those variables are then used in :
to display a "no entry for that letter" message when browsing alphabetically in the sections "Persons", "Organizations"' "Research" and "Events":
Additionally, this concatenation tends to creates grammar problems in non-English context, which makes it both a general and i18n issue.
Since there is redundancy between the labels (see screenshots), a possible solution would be to ditch the concatenated message altogether, and display a simple "No entry starting with letter x"