chenejac / VIVOTestMigrationJIRA

0 stars 0 forks source link

VIVO-1875: i18n : grammar problems in French forms of "Events" section #1766

Closed chenejac closed 3 years ago

chenejac commented 4 years ago

Nicolas B Dickn (Migrated from VIVO-1875) said:

In Event section, several forms are pulling autoCompleteObjectPropForm_fr_CA.ftl, such as (list probably not exhaustive) :

That ftl file concatenates several variables, which creates grammar problems in French. A quick fix added directly into the code was solving somes cases, while breaking others :

<p> <label for="object"> ${i18n().name_capitalized?cap_first} *{color:#de350b}de la{color}* ${propertyNameForDisplay?lower_case} <span class='requiredHint'> *</span></label> <input class="acSelector" size="50" type="text" id="object" name="objectLabel" acGroupName="object" value="${objectLabel}" /> </p> The real fix would be much the same as https://github.com/vivo-project/VIVO-languages/pull/43

chenejac commented 3 years ago

Nicolas B Dickn said:

Also fixed by https://github.com/vivo-project/VIVO-languages/pull/82

chenejac commented 3 years ago

Andrew Woods said:

Resolved with: https://github.com/vivo-project/VIVO-languages/commit/ac4867ee202ce2777af660dd37dde3510bbfa024