search

chenejac / VIVOTestMigrationJIRA

0 stars 0 forks source link

VIVO-1892: i18n: make the Capability Map template i18n compatible #1782

Closed chenejac closed 4 years ago

chenejac commented 4 years ago

Dominik Feldschnieders (Migrated from VIVO-1892) said:

We started to make the control buttons and other stuff for the Capability Map i18n compatible.

It has been noticed that we could make the whole template i18n compatible if we pull the hardcoded language text from those .ftl files into properties.

 

So in this ticket all text from the Capability Map template should be replaced with i18n-properties und pull into the property-file.

In addition the property-files for the Capability Map in VIVO-languages should be updated and the language specific templates can be deleted

chenejac commented 4 years ago

Dominik Feldschnieders said:

PR 1: [https://github.com/vivo-project/VIVO/pull/179]

PR 2: [https://github.com/vivo-project/VIVO-languages/pull/61]

Now everything should be translated if you switch the language with one small exception...the image on the lower right side. It is only available in english

 

chenejac commented 4 years ago

Andrew Woods said:

Now everything should be translated if you switch the language with one small exception...the image on the lower right side. It is only available in english

..which image?

chenejac commented 4 years ago

Andrew Woods said:

Resolved with: https://github.com/vivo-project/VIVO/commit/48acad04d123e76677e53709fcec4c228168867b and https://github.com/vivo-project/VIVO-languages/commit/2c47b73688f6ceacdf8f7bda055ee2c2147cf5fd

chenejac commented 4 years ago

Christian Hauschke said:

..which image?

!https://vivo-development.hs-mittweida.de/vivo-i18n/images/visualization/capabilitymap/key.png!