chenejac / VIVOTestMigrationJIRA

0 stars 0 forks source link

VIVO-1902: i18n: Capability Map - provide an translated image for every language #1792

Closed chenejac closed 3 years ago

chenejac commented 4 years ago

Dominik Feldschnieders (Migrated from VIVO-1902) said:

Follow up Ticket for https://jira.lyrasis.org/browse/VIVO-1892

On site "Capability Map" there is an image on the bottom right (see screenshot) and this is only available in english. (without language tag)

There should be an image for every existing language and the code where it is embedded also requires adjustments.

 

 

 

chenejac commented 4 years ago

Andrew Woods said:

Thanks. I believe another option that we may want to explore is to remove the image and create a similar table via css/template/properties.

chenejac commented 4 years ago

Christian Hauschke said:

Replacing the image with text would be much better IMHO. It cannot be translated in new languages, and it's not accessible. two very good reasons to get rid of it.

chenejac commented 3 years ago

Matthias Lühr said:

[https://github.com/vivo-project/VIVO/pull/184]

[https://github.com/vivo-project/VIVO-languages/pull/66]

 

chenejac commented 3 years ago

Andrew Woods said:

Pending response to code review comments.

chenejac commented 3 years ago

Andrew Woods said:

Looks good... once the merge conflict has been resolved. https://github.com/vivo-project/VIVO-languages/pull/66

chenejac commented 3 years ago

Andrew Woods said:

Updated pull-requests:

chenejac commented 3 years ago

Andrew Woods said:

Resolved with: https://github.com/vivo-project/VIVO/commit/3aa59cf6eaa339df6c9b0ed9cc1427258814782b and https://github.com/vivo-project/VIVO-languages/commit/673b5841b11e54bfd3ffc8a2cce3e0253c828e6a

chenejac commented 2 years ago

This issue duplicates #1721