chenejac / VIVOTestMigrationJIRA

0 stars 0 forks source link

VIVO-1905: sprint-i18n: Modify RDF files only to include new needed triple content; retain existing syntax #1795

Closed chenejac closed 4 years ago

chenejac commented 4 years ago

Brian Lowe (Migrated from VIVO-1905) said:

The sprint-i18n branch appears to include a systematic reserialization of RDF files in home/resources/rdf to N3 format.  While this standardization is a good goal for the future, it complicates the process of reviewing functional changes for merging the i18n developments into the core code.  It also means that some comment lines included in the original files are now lost, and potentially creates problems for people who have made local RDF file modifications in their third tiers.

The RDF files should be analyzed for actual content differences from master, and only the new content (or modifications) should be applied.  The original file syntax should be preserved for now.

chenejac commented 4 years ago

Andrew Woods said:

To facilitate the process of identifying the model-level differences in the original RDF serializations and the re-serializations, the following tool should be of help: https://github.com/awoods/rdftools

chenejac commented 4 years ago

Andrew Woods said:

The attached files document which RDF files are different between the spring-i18n and master branches: vitro-rdf.txt vivo-langs-i18n-to-master-rdf.txt vivo-langs-master-to-i18n-rdf.txt vivo-rdf.txt

chenejac commented 4 years ago

Andrew Woods said:

Pull-requests: https://github.com/vivo-project/Vitro/pull/177 https://github.com/vivo-project/VIVO/pull/180

chenejac commented 4 years ago

Brian Lowe said:

[https://github.com/vivo-project/Vitro/commit/e40401225a6b3388eabec8be7616cc648429605f]

[https://github.com/vivo-project/VIVO/commit/2c0d6817a9c4a7fad26e4870f8164c71ac4c694b]