chenejac / VIVOTestMigrationJIRA

0 stars 0 forks source link

VIVO-1909: 'Edit this Individual' form strips language tags and adds langString datatype #1799

Closed chenejac closed 4 years ago

chenejac commented 4 years ago

Benjamin Gross (Migrated from VIVO-1909) said:

I'm running into a problem where a 'langString' type is being added to labels if I edit them in the UI. The literal type isn't included when I first add the object, only when I edit it.

Mentioned here: [https://groups.google.com/u/2/g/vivo-tech/c/bjBcAJo8ldE/m/xgOfBPcZAwAJ?pli=1]

Regardless of whether giving labels a langString type is correct or not, the current behavior of adding it when editing has the undesirable effect of breaking alphabetical sorting in list views. And strange that this only happens when editing, creating a new object/label gives it the language tag tied to the current site locale.

!Screen Shot 2020-07-15 at 16.40.57.png|width=431,height=275!

!image-2020-07-17-19-11-09-367.png|width=447,height=316!

This appears to be tied to a difference in how strings were treated between Jena 2 and 3 and subsequently discussed here: [https://wiki.lyrasis.org/display/VIVODOC111x/Data+types+for+string+and+language]

chenejac commented 4 years ago

Benjamin Gross said:

Pull request: [https://github.com/vivo-project/Vitro/pull/175]

chenejac commented 4 years ago

Brian Lowe said:

https://github.com/vivo-project/Vitro/commit/119413413a53cd6ebcbff50d3501f32f72aff6f0