search

chenejac / VIVOTestMigrationJIRA

0 stars 0 forks source link

VIVO-1915: i18n - Adding a label with language tag through the "new" manageLabelsForindividualAddForm.ftl does not take the setting for language tag #1805

Closed chenejac closed 4 years ago

chenejac commented 4 years ago

Dominik Feldschnieders (Migrated from VIVO-1915) said:

With a fresh VIVO instanz and the given sample data ([https://wiki.lyrasis.org/display/VIVODOC19x/Sample+Data]) i added a label/title to an instanz in an different language (f.e. german). Now you can click the button right of the label to "manage labels". You see the first initial english label and my german label.

If you try to add another label (the "main" language selection is set to english, upper right corner) with the button "Add Label" and you choose for example "French (Canada)" and click "Save". The Label will be listed as english (see images).

I think instead of using the selection the general language selection is used. If you select french as language of the interface it works as expected or is this an intentional behavior?

I am working in the "sprint-i18n" branch so i do not know which versions are affected. I think this functionality is new

chenejac commented 4 years ago

Andrew Woods said:

Related files:

chenejac commented 4 years ago

Benjamin Gross said:

I agree, it appears to use the currently selected locale, regardless of which language is selected in the dropdown. Tested with German. It doesn't work with spanish at all (@es as the locale).

chenejac commented 4 years ago

Andrew Woods said:

Spanish issue is likely due to: https://jira.lyrasis.org/browse/VIVO-1900

chenejac commented 4 years ago

Dominik Feldschnieders said:

[Github PR|[https://github.com/vivo-project/Vitro/pull/184]] 

I have also tested a few other places and found no problems with the fix but maybe someone with more experience in this area of the software should look at it and tell me if this is the right way to fix it.

chenejac commented 4 years ago

Andrew Woods said:

After team discussion, it was decided that the resolution to this ticket should be to remove the in-form language dropdown for the edit-label page... and as a result, rely on the language context set at the site-level to determine the langTag for added labels.

chenejac commented 4 years ago

Dominik Feldschnieders said:

[1 PR|[https://github.com/vivo-project/Vitro/pull/184]]

[2 PR|[https://github.com/vivo-project/VIVO/pull/190]]

I removed the language selection on both templates.

I left some comments in the first PR, any thoughts on this?

chenejac commented 4 years ago

Andrew Woods said:

Pending response to code review.

chenejac commented 4 years ago

Dominik Feldschnieders said:

[1 PR|[https://github.com/vivo-project/Vitro/pull/184]]  with description

[2 PR|[https://github.com/vivo-project/VIVO/pull/190]]

[3 PR|[https://github.com/vivo-project/Vitro-languages/pull/31]]

all in all briefly summarized:

 

chenejac commented 4 years ago

Andrew Woods said:

The functionality of only showing an "Add label" button if you are in a language context that does not currently have a label takes a little getting used to... but makes sense. Nice work.

chenejac commented 4 years ago

Andrew Woods said:

Resolved with:

chenejac commented 3 years ago

This issue is related to #1815